On Mon, Nov 17, 2014 at 11:24, Tobias Stoeckmann wrote:
> On Sun, Nov 16, 2014 at 06:38:24PM -0500, Ted Unangst wrote:
>> Not sure how I ended up reading this file, but all the redundant
>> strlen calls make me twitchy.
> 
> I agree, but have you considered the other parser.c files with
> match_token and same use of strlen(word), too?
> 
> src/usr.sbin/dvmrpctl/parser.c
> src/usr.sbin/ikectl/parser.c
> src/usr.sbin/iscsictl/parser.c
> src/usr.sbin/ldpctl/parser.c
> src/usr.sbin/npppctl/parser.c
> src/usr.sbin/ospf6ctl/parser.c
> src/usr.sbin/ospfctl/parser.c
> src/usr.sbin/relayctl/parser.c
> src/usr.sbin/ripctl/parser.c
> src/usr.sbin/snmpctl/parser.c

One at a time, one at a time. :)

Reply via email to