On 9 December 2014 at 19:00, Christian Weisgerber <[email protected]> wrote: > On 2014-12-03, Mike Belopuhov <[email protected]> wrote: > >> bpf aligns data following the datalink header (e.g. ethernet) >> on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's >> uint32_t instead of a long. And also since then almost all >> packets become "unaligned" from the tcpdump perspective and >> require costly copies into the internal buffer. Neither IP >> header (struct ip) nor IPv6 (struct ip6_hdr) have fields >> larger than 32 bits and therefore alignment requirements for >> them are at most 32 bit. >> >> I've successfully tested this diff on sparc64 and amd64. > > Oops, turns out I've had the same diff in my tree on my sparc64 for > a long time (last year?). No ill effects, but I do little tcpdumping > on that machine. > > I think you have forgotten a chunk in print-atalk.c: >
I did not. I can't test AppleTalk, so if you can, please do so. By analogy it looks correct (:
