On Thu, Dec 11, 2014 at 6:22 AM, Martin Pieuchot <[email protected]> wrote: > Thanks for all your comments. I though a bit more about this change and > decided to: > > - Simply return the number of bytes written/read upon success and -1 > otherwise (à la read/write). This allows us to remove some usages > of "usbd_status" when we are not directly manipulating a "xfer" > object. > > - Always consider a short transfer for SET requests as failures. > > So the diff below includes your changes to upd(4) that I'll commit > separately if you're ok. > > Concerning your remark about the USB_SET_IMMED ioctl(2), it doesn't > really matter, this interface is not used and should be removed. >
Aside from what kettenis@ already saw, I also notice that uhidev_use_rdesc and ukbd_set_leds don't check their set_report calls, but that was the case in the previous code too. Other than that, the diff looks good and runs my UPS fine. Commit in whatever chunks you deem appropriate. Thanks. --david
