On Fri, Dec 12, 2014 at 10:45:04AM -0700, Todd C. Miller wrote:
> On Fri, 12 Dec 2014 18:16:35 +0100, Tobias Stoeckmann wrote:
>
> > chmod doesn't check if the program name is at least 3 characters long
> > before checking its index 2.
>
> OK.
Just throwing this out there: will this program ever get
installed with filename shorter than ch{grp,mod,own,flags}?
--patrick
> > Also, there is a compiler warning about signed vs unsigned when "val"
> > is used. In one instance, it's used with strtoul, in another with strtol,
> > checking its ranges. It's okay due to automatic casting but definitely
> > no clean code.
>
> OK. This is still a comparision between signed and unsigned but
> since INT_MAX is a constant the compiler can tell that it is safe.
>
> - todd
>
