> On 16 Jan 2015, at 20:45, Fritjof Bornebusch <frit...@alokat.org> wrote:
>
> Hi tech@,
>
> aren't these functions supposed to be static?
no, static functions in the kernel means the debugger cant see their names, and
we like seeing things in the debugger.
they probably should be static in userland though...
>
> fritjof
>
>
> Index: siphash.c
> ===================================================================
> RCS file: /cvs/src/sys/crypto/siphash.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 siphash.c
> --- siphash.c 4 Nov 2014 03:01:14 -0000 1.1
> +++ siphash.c 16 Jan 2015 10:41:37 -0000
> @@ -48,8 +48,8 @@
>
> #include <crypto/siphash.h>
>
> -void SipHash_CRounds(SIPHASH_CTX *, int);
> -void SipHash_Rounds(SIPHASH_CTX *, int);
> +static void SipHash_CRounds(SIPHASH_CTX *, int);
> +static void SipHash_Rounds(SIPHASH_CTX *, int);
>
> void
> SipHash_Init(SIPHASH_CTX *ctx, const SIPHASH_KEY *key)
> @@ -147,7 +147,7 @@ SipHash(const SIPHASH_KEY *key, int rc,
>
> #define SIP_ROTL(x, b) ((x) << (b)) | ( (x) >> (64 - (b)))
>
> -void
> +static void
> SipHash_Rounds(SIPHASH_CTX *ctx, int rounds)
> {
> while (rounds--) {
> @@ -171,7 +171,7 @@ SipHash_Rounds(SIPHASH_CTX *ctx, int rou
> }
> }
>
> -void
> +static void
> SipHash_CRounds(SIPHASH_CTX *ctx, int rounds)
> {
> u_int64_t m = lemtoh64((u_int64_t *)ctx->buf);
