Steven McDonald wrote: > The recent change to db_variables.c to not include sys/systm.h revealed > a missing include that breaks kernel builds on macppc (and possibly > other arches). The problem is that db_variables.c makes use of > strcmp(9), which requires lib/libkern/libkern.h, and that was being > included via systm.h. > > This problem doesn't manifest on amd64, i386 or sparc64 because their > machdep/db_machdep.h includes libkern.h via a different route > (uvm/uvm_extern.h -> uvm/uvm_map.h -> sys/systm.h).
Thanks. I restored the systm.h include instead. It's rare for C files to include libkern headers directly. I think systm.h remains the correct header for strcmp.
