On 03/15/15 21:01, Kamil Rytarowski wrote: > Brian Callahan wrote: >> On 03/15/15 19:24, Kamil Rytarowski wrote: >>> Hello, Currently sysdef.h includes C headers for little purpose, as >>> the same headers are already pulled in appropriate .c files. In the >>> result the headers listed in sysdef.h are pulled in twice. I propose >>> to move the remaining content (literally 11 lines-of-code) to def.h or >>> a better place. I think that back in time all system includes were >>> pulled in from sysdef.h, today I see no need for it any more. >> I'm not sure you've tried doing that. There's a warning to include those >> files in order for a reason. >> >> However, there are some files that have redundant includes. Below is a >> diff to remove those. >> >> OK? >> > Thank you, this is another approach. OK from me!
No no. When I say "OK?" I'm asking another developer to look at it and say whether or not I can commit it. Anyhow I've talked to Theo about this and I will be bringing mg in line with the rest of how OpenBSD handles includes. ~Brian
