Hi tech@
I'm the maintainer of www/otter-browser and I got caught while packaging
otter-browser 0.9.04. Upstream asked us to point at a different commit
then the tagged revision so we did:
GH_TAGNAME = v0.9.04
# This is the actual tagged revision
# GH_COMMIT = 869d29d19719b3057e137a79d4a10025d2c920f6
# but we were asked by upstream to release from the following commit
# as it's considered an important fix affecting the majority of users
GH_COMMIT = 23d7ee6f9cd636e750687a01975b177c1c9c2e53
This port was reviewed with an ok by two people and underwent further
changes later on.
I didn't notice that the port actually packaged GH_TAGNAME contents
instead of GH_COMMIT.
Current documentation for both tags are as follows:
GH_COMMIT SHA1 commit id to fetch. It is good practice to
always
specify the commit id, even if ${GH_TAGNAME} was
specified.
GH_TAGNAME Name of the tag to download. Setting ${GH_TAGNAME}
to
master is invalid and will throw an error.
${WRKDIST} is
auto-generated based on the ${GH_TAGNAME} if
specified,
otherwise ${GH_COMMIT} will be used to generate
${WRKDIST}.
I would like to suggest a small alteration to GH_COMMIT to point out
that
GH_TAGNAME takes precedence even if they point at different changeset.
The ports system doesn't warn about that situation and I almost got
caught
by it twice since upstream again asks us to package a couple of
revisions
ahead of the tagged version.
Regards,
Adam
Index: bsd.port.mk.5
===================================================================
RCS file: /cvs/src/share/man/man5/bsd.port.mk.5,v
retrieving revision 1.415
diff -u -p -r1.415 bsd.port.mk.5
--- bsd.port.mk.5 3 Apr 2015 10:19:22 -0000 1.415
+++ bsd.port.mk.5 4 Apr 2015 20:58:59 -0000
@@ -1703,6 +1703,7 @@ Account name of the GitHub user hosting
SHA1 commit id to fetch.
It is good practice to always specify
the commit id, even if ${GH_TAGNAME} was specified.
+${GH_TAGNAME} takes precedence even if ${GH_COMMIT} points at a
different changeset.
.It Ev GH_PROJECT
Name of the project on GitHub.
.It Ev GH_TAGNAME
