On 8 April 2015 at 12:46, Martin Pieuchot <m...@openbsd.org> wrote: > On 08/04/15(Wed) 12:15, Mike Belopuhov wrote: >> OK to rename gettdbbyaddr to gettdbbydst since that's what it does >> and it aligns well with gettdbbysrc? > > Makes sense to me. This is also coherent to the comments in ip_ipsp.h. > > One comment though, you're moving a splsoftnet() in tdb_delete() but it > seems that the hash function does not need this protection, or am I > misunderstanding something? >
Just a better place for it to be. Especially if somebody will turn it into something else. There's no functional change.
