On Wed, Apr 15, 2015 at 10:14 AM, Philip Guenther <[email protected]> wrote: > On Wed, Apr 15, 2015 at 5:48 AM, Manuel Giraud <[email protected]> wrote: >> Here is a patch that eliminate the -U flag for dump and make usage of >> DUID in /etc/dumpdates the default. It also correct old style entries so >> nothing has to be done for the admin :) > > Yeah, I've started using this and it looks good so far. Just a couple > corner cases to verify tonight and presuming it looks good I'll commit > tonight.
Heh, "tonight", riiiight... So the diff itself does what I expect, but running with it has revealed that the -w and -W options need work. Consider this output: : morgaine; dump -w Dump these file systems: /dev/rsd0i (/usr/src) Last dump: Level 0, Date Wed Apr 8 11:14 /dev/rsd0k ( /home) Last dump: Level 4, Date Wed Mar 25 00:33 : morgaine; dump -W Last dump(s) done (Dump '>' file systems): /dev/rsd0f ( /usr) Last dump: Level 0, Date Thu Mar 13 10:29 > /dev/rsd0i (/usr/src) Last dump: Level 0, Date Wed Apr 8 11:14 > /dev/rsd0k ( /home) Last dump: Level 4, Date Wed Mar 25 00:33 a7df1ec64e79a49c.i ( ) Last dump: Level 2, Date Wed Apr 15 09:56 a7df1ec64e79a49c.k ( ) Last dump: Level 6, Date Sat May 2 18:32 : morgaine; egrep 'src|home' /etc/fstab /dev/sd0k /home ffs ro,nodev,softdep 6 2 /dev/sd0i /usr/src ffs ro,nodev,nosuid,softdep 6 2 : morgaine; Yes, DUID a7df...49c is sd0, so the dump -w output is incorrect: last dump of /home was just minutes ago, recorded under the DUID. Yes, the output is correct once I change /etc/fstab to use the DUID, but if we're going to automatically switch to DUIDs for /etc/dumpdates then we should match them up automatically too. So I'll commit your diff; you wanna switch at doing the matching for -w/-W ? Philip Guenther
