On 2015/05/12 16:35, Mikhail wrote: > Hello, inlined patch is a compilation of fixes which were pushed into > FreeBSD tree after 8188eu driver came in. > > It adds four new usbdevs (r270191, r273589, r282120), fixes efuse length > and replaces magic numbers with proper defines (r281918), fixes efuse > access (r281592, r282623), and fixes man typo. > > All revisions can be viewed by this url pattern: > > https://svnweb.freebsd.org/base?view=revision&revision=<revision> > > Efuse changes from those revisions are overlapping, patch incorporates > final version.
Seems reasonable to me. Minor manpage issue: > Index: share/man/man4/urtwn.4 > =================================================================== > RCS file: /cvs/src/share/man/man4/urtwn.4,v > retrieving revision 1.33 > diff -u -p -r1.33 urtwn.4 > --- share/man/man4/urtwn.4 4 May 2015 14:30:06 -0000 1.33 > +++ share/man/man4/urtwn.4 11 May 2015 12:20:23 -0000 > @@ -28,7 +28,7 @@ The > driver supports USB 2.0 wireless network devices based on Realtek > RTL8188CUS, RTL8188CE-VAU, RTL8188EUS, RTL8188RU and RTL8192CU chipsets. > .Pp > -The RTL8188CUS and RTL8188EUS are a highly integrated 802.11n adapter > +The RTL8188CUS and RTL8188EUS are a highly integrated 802.11n adapters > that combines a MAC, a 1T1R capable baseband and an RF in a single chip. > It operates in the 2GHz spectrum only. Should be: The RTL8188CUS and RTL8188EUS are highly integrated 802.11n adapters that combine a MAC, a 1T1R capable baseband and an RF in a single chip. They operate in the 2GHz spectrum only. Rest is OK with me (though untested as I don't have a urtwn).
