On 14/05/15(Thu) 08:20, sven falempin wrote: > On Thu, May 14, 2015 at 6:27 AM, Martin Pieuchot <[email protected]> wrote: > > one level of indentation. > > > > pre > if (X == null ) {dprintf(you broke this); return ;} > unindented code; > /pre > > Same gain, more dev ease and corner case check.
I disagree. Adding such check is painful because we have to maintain more code to deal with the impossible but we now kind-of-safe case where ifp is NULL. And what should happen once your CPU returned from this function? Having a good NULL pointer dereference is a much better choice.
