This got me looking at the code first.

No need to assign argc and maxargc twice.
Found by llvm/scan-build

--- fsck.c.p1   Fri May 29 11:01:25 2015
+++ fsck.c      Fri May 29 11:02:18 2015
@@ -449,9 +447,6 @@ mangle(char *opts, int *argcp, const cha
        char *p, *s;
        int argc = *argcp, maxargc = *maxargcp;
        const char **argv = *argvp;
-
-       argc = *argcp;
-       maxargc = *maxargcp;

        for (s = opts; (p = strsep(&s, ",")) != NULL;) {
                /* always leave space for one more argument and the NULL */

Reply via email to