Three minor nits following up on differences between the versions in
reyk@'s mails and the initial commit:

- <assert.h> isn't used anymore, so it can be removed.

- Sort the remaining headers alphabetically according to style(9).

- There's one remaining '%%' in an error string that shouldn't
  be doubled, I think.

Index: usr.sbin/httpd/patterns.c
===================================================================
RCS file: /cvs/src/usr.sbin/httpd/patterns.c,v
retrieving revision 1.2
diff -u -p -r1.2 patterns.c
--- usr.sbin/httpd/patterns.c   23 Jun 2015 15:35:20 -0000      1.2
+++ usr.sbin/httpd/patterns.c   26 Jun 2015 09:18:16 -0000
@@ -30,12 +30,11 @@
  * Standard library for string operations and pattern-matching
  */
 
+#include <ctype.h>
+#include <errno.h>
 #include <stddef.h>
 #include <stdlib.h>
 #include <string.h>
-#include <ctype.h>
-#include <errno.h>
-#include <assert.h>
 
 #include "patterns.h"
 
@@ -98,7 +97,7 @@ classend(struct match_state *ms, const c
        case L_ESC:
                if (p == ms->p_end)
                        match_error(ms,
-                           "malformed pattern (ends with '%%')");
+                           "malformed pattern (ends with '%')");
                return p + 1;
        case '[':
                if (*p == '^')

Reply via email to