Miod Vallat, 01 Jul 2015 21:35:
> > spoke to soon, other anciet drivers need something like
> > that.
> 
> Physical address should be printed with %p rather than 0x%x.

explicit cast ok?

-f
-- 
why did kamikaze pilots wear helmets anyway?
Index: dev/eisa/aha1742.c
===================================================================
RCS file: /cvs/src/sys/dev/eisa/aha1742.c,v
retrieving revision 1.44
diff -u -p -r1.44 aha1742.c
--- dev/eisa/aha1742.c  14 Sep 2014 14:17:24 -0000      1.44
+++ dev/eisa/aha1742.c  1 Jul 2015 22:21:35 -0000
@@ -957,7 +957,7 @@ ahb_scsi_cmd(xs)
                 * Set up the scatter gather block
                 */
                SC_DEBUG(sc_link, SDEV_DB4,
-                   ("%d @0x%x:- ", xs->datalen, xs->data));
+                   ("%d @%p:- ", xs->datalen, (void *)xs->data));
                datalen = xs->datalen;
                thiskv = (long) xs->data;
                thisphys = KVTOPHYS(thiskv);
@@ -968,7 +968,7 @@ ahb_scsi_cmd(xs)
                        /* put in the base address */
                        sg->seg_addr = thisphys;
 
-                       SC_DEBUGN(sc_link, SDEV_DB4, ("0x%x", thisphys));
+                       SC_DEBUGN(sc_link, SDEV_DB4, ("%p", (void *)thisphys));
 
                        /* do it at least once */
                        nextphys = thisphys;
Index: dev/ic/uha.c
===================================================================
RCS file: /cvs/src/sys/dev/ic/uha.c,v
retrieving revision 1.24
diff -u -p -r1.24 uha.c
--- dev/ic/uha.c        14 Sep 2014 14:17:25 -0000      1.24
+++ dev/ic/uha.c        1 Jul 2015 22:21:35 -0000
@@ -358,7 +358,7 @@ uha_scsi_cmd(xs)
                 * Set up the scatter gather block
                 */
                SC_DEBUG(sc_link, SDEV_DB4,
-                   ("%d @0x%x:- ", xs->datalen, xs->data));
+                   ("%d @%p:- ", xs->datalen, (void *)xs->data));
                datalen = xs->datalen;
                thiskv = (int) xs->data;
                thisphys = KVTOPHYS(thiskv);
@@ -369,7 +369,7 @@ uha_scsi_cmd(xs)
                        /* put in the base address */
                        sg->seg_addr = thisphys;
 
-                       SC_DEBUGN(sc_link, SDEV_DB4, ("0x%x", thisphys));
+                       SC_DEBUGN(sc_link, SDEV_DB4, ("%p", (void *)thisphys));
 
                        /* do it at least once */
                        nextphys = thisphys;
Index: dev/isa/wds.c
===================================================================
RCS file: /cvs/src/sys/dev/isa/wds.c,v
retrieving revision 1.42
diff -u -p -r1.42 wds.c
--- dev/isa/wds.c       14 Sep 2014 14:17:25 -0000      1.42
+++ dev/isa/wds.c       1 Jul 2015 22:21:35 -0000
@@ -931,7 +931,7 @@ wds_scsi_cmd(struct scsi_xfer *xs)
                 * Set up the scatter-gather block.
                 */
                SC_DEBUG(sc_link, SDEV_DB4,
-                   ("%d @0x%x:- ", xs->datalen, xs->data));
+                   ("%d @%p:- ", xs->datalen, (void *)xs->data));
 
                datalen = xs->datalen;
                thiskv = (int)xs->data;
@@ -943,7 +943,7 @@ wds_scsi_cmd(struct scsi_xfer *xs)
                        /* put in the base address */
                        ltophys(thisphys, sg->seg_addr);
 
-                       SC_DEBUGN(sc_link, SDEV_DB4, ("0x%x", thisphys));
+                       SC_DEBUGN(sc_link, SDEV_DB4, ("%p", (void *)thisphys));
 
                        /* do it at least once */
                        nextphys = thisphys;

Reply via email to