On Fri, Jul 10, 2015 at 07:10:00AM -0500, Vladimir Támara Patiño wrote: > > Looks good to me. > > I though it was necessary to include __mb_cur_max in _locale_t (as FreeBSD > and DragonFly do in their xlocale_ctype in mblocal.h) but just now I noticed > that it is already included in lc_ctype->rl_citrus_ctype > > Thanks for your work. >
There are more patches coming (11 patches for now). Only 4 have been proposed to review for now. __mb_cur_max is on the list of changes. Yes, as you noted, it is included in locale->lc_ctype->rl_citrus_ctype. __mb_cur_max isn't defined by POSIX, but MB_CUR_MAX (as a macro). So __mb_cur_max will be changed from variable to function, in order to retrieve locale->lc_ctype->rl_citrus_ctype->cc_mb_cur_max from the current locale (global or per-thread). In the same way _ctype_, _tolower_tab_ and _toupper_tab_ will be changed (defined in <ctype.h>) to dynamically retrieve their values from the current locale. Thanks for you reviewing. -- Sebastien Marie
