On 15/07/15(Wed) 16:45, Ludovic Coues wrote:
> Following is a diff adding missing USB descriptor to uvideo.h according
> to USB Video spec 1.5 . It also update a couple of table reference from
> spec 1.1 to 1.5
Do not hesitate to explain *why* do you need that, it might not be clear
to everybody on this list :)
> Index: sys/dev/usb/uvideo.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/uvideo.h,v
> retrieving revision 1.57
> diff -u -p -r1.57 uvideo.h
> --- sys/dev/usb/uvideo.h 9 Jul 2015 14:58:32 -0000 1.57
> +++ sys/dev/usb/uvideo.h 14 Jul 2015 17:24:42 -0000
> +/* Table 3-18: Still Image Frame Descriptor */
> +struct usb_video_still_image_frame_desc {
> + uByte bLength;
> + uByte bDescriptorType;
> + uByte bDescriptorSubtype;
> + uByte bEndpointAddress;
> + uByte bNumImageSizePatterns;
> + uByte data[1];
> +/* struct {
> + uWord wWidth;
> + wWord wHeight;
> + } __packed size[1]; */
> +/* uByte bNumCompressionPattern; */
> +/* uByte bCompression[1]; */
Why are they commented?
> +} __packed;
> +
> +/* Table 3-19: Color Matching Descriptor */
> struct usb_video_color_matching_descr {
> uByte bLength;
> uByte bDescriptorType;
