>This is another trivial patch, but I've always found the disklabel
>message "No label changes" confusing. For example, if you print (p), add
>a label (a), write (w), print to check your changes (p), and then quit
>(q), it seems odd to be told "No label changes". 
>
>
>
>Index: sbin/disklabel/editor.c
>===================================================================
>RCS file: /cvs/src/sbin/disklabel/editor.c,v
>retrieving revision 1.295
>diff -u -p -r1.295 editor.c
>--- sbin/disklabel/editor.c    8 May 2015 12:15:50 -0000       1.295
>+++ sbin/disklabel/editor.c    17 Jul 2015 02:54:59 -0000
>@@ -373,7 +373,7 @@ editor(int f)
>                        */
>                       if (!dflag && !aflag &&
>                           memcmp(&lab, &newlab, sizeof(newlab)) == 0) {
>-                              puts("No label changes.");
>+                              puts("No further label changes.");
>                               /* Save mountpoint info. */
>                               mpsave(&newlab);
>                               goto done;

The phrase "No label changes." was selected because it is true
(there is nothing to save).  I don't see what "further" adds to
make this more accurate or understandable.

Reply via email to