On Mon, Jul 20, 2015 at 12:38:19AM +0200, Hrvoje Popovski wrote: > On 20.7.2015. 0:06, Mark Kettenis wrote: > > The acpi code that reads and writes pci config space is quite busted. > > It always does byte-sized reads and writes even if the aml specifies > > an access size of four bytes. This made vmware unhappy, because it > > expetcs to see a magic value being written into a 32-bit register and > > not the individual bytes. But even on real hardware registers with > > semantics like that exist. > > > > The diff below fixes this issue by respecting the access size. It > > still does read/modify write cycles for 16-bit and 8-bit writes, but > > those should be ok. > > > > I can't even imagine all the different acpi issues this might fix or > > introduce. So please try this on as many machines as you can and > > report any regressions. > > > > > > > Hi, > > I have applied you patch on ibm x3550 m4 and box won't boot. > I'm not sure is this because your patch or not. If yes I will post > everything that i can in this thread, if not I will open other thread. > > Here's link to screenshot. > http://kosjenka.srce.hr/~hrvoje/zaprocvat/ibm_x3550_m4_01 > >
I'm pretty sure that's a different problem. But thanks for pointing this out. -ml