Re: Potential free uninitialized pointer in kern_ktrace.c

[Doug Hogan]

On Sat, Aug 01, 2015 at 07:31:58PM +0100, Mark Latimer wrote:
> reading through the compiler warnings I believe there is a potential issue
> in /usr/src/sys/kern/kern_ktrace.c At first glance it appears to free
> an uninitialized pointer memp.

I agree.


Index: sys/kern/kern_ktrace.c
===================================================================
RCS file: /cvs/src/sys/kern/kern_ktrace.c,v
retrieving revision 1.74
diff -u -p -r1.74 kern_ktrace.c
--- sys/kern/kern_ktrace.c      19 Jul 2015 04:45:25 -0000      1.74
+++ sys/kern/kern_ktrace.c      1 Aug 2015 18:55:44 -0000
@@ -348,7 +348,7 @@ ktruser(struct proc *p, const char *id, 
        struct ktr_header kth;
        struct ktr_user ktp;
        int error;
-       void *memp;
+       void *memp = NULL;
 #define        STK_PARAMS      128
        long long stkbuf[STK_PARAMS / sizeof(long long)];