On Thu, Aug 20, 2015 at 01:37:00PM +0200, Martin Pieuchot wrote:
> --- net/route.c       19 Aug 2015 13:27:38 -0000      1.223
> +++ net/route.c       20 Aug 2015 11:25:54 -0000
> @@ -570,12 +570,8 @@ rtdeletemsg(struct rtentry *rt, u_int ta
>       info.rti_flags = rt->rt_flags;
>       ifp = rt->rt_ifp;
>       error = rtrequest1(RTM_DELETE, &info, rt->rt_priority, &rt, tableid);
> -

Should we add a comment here, why we must keep the route during
rt_missmsg()?

>       rt_missmsg(RTM_DELETE, &info, info.rti_flags, ifp, error, tableid);
> -
> -     /* Adjust the refcount */
> -     if (error == 0 && rt->rt_refcnt <= 0) {
> -             rt->rt_refcnt++;
> +     if (error == 0) {
>               rtfree(rt);
>       }

Remove the {}.

OK bluhm@

Reply via email to