Renaud Allard wrote: > On 08/26/2015 06:39 PM, Michael Reed wrote: > > Hi Renauld, > > > > On 08/26/15 09:38, Renaud Allard wrote: > >> I rewrote a little bit the patch to remove a small kind-of typo in the > >> manpage and remove too long lines. > >> So with this patch, you add the user the right to choose the > >> authentication style and administratively, in login.conf, you can restrict > >> it. > >> > >> Any comments? OK? > > > > I left some comments inline > > > > > > The usage string under SYNOPSIS should be updated too. > > > > > > I think the two instances of `/etc/login.conf' should be specified using > > the Pa macro, so that doas(1) also shows up if `apropos Pa=/etc/login.conf' > > is executed, which currently gives plenty of results. > > > > > > Instead of ``...'', I think Sq or Dq should be used. > > > > I rewrote the patch with the suggested modifications. Any more comments? > Is it OK?
Sorry, I think adding an option is too much. I just committed halex's original diff to only change the type. I thought he was going to do that by now.
