On Sun, Aug 30, 2015 at 06:22:14PM +1200, Richard Procter wrote: > * constify local aliases > > - enables compilation to verify they are never reassigned > > ok?
Your next patch [2/24] does remove this line, so no need for this one, right? > to apply: > $ cd /usr/src/sys > $ cat - | patch > > Index: net/pf.c > =================================================================== > --- net.orig/pf.c > +++ net/pf.c > @@ -4490,7 +4490,7 @@ int > pf_test_state_icmp(struct pf_pdesc *pd, struct pf_state **state, > u_short *reason) > { > - struct pf_addr *saddr = pd->src, *daddr = pd->dst; > + struct pf_addr *const saddr = pd->src, *const daddr = pd->dst; > u_int16_t virtual_id, virtual_type; > u_int8_t icmptype; > int icmp_dir, iidx, ret, copyback = 0; >