Martijn van Duren wrote:
> Hello tech@,
> 
> I took a quick glance at ksh and one of the first things I noticed was 
> that it uses some sanatizing code on argv. When looking at execve(2) I 
> see that EINVAL or EFAULT are returned when argv isn't properly 
> formatted. I've also verified this quickly by a small PoC and in 
> sys/kern/kern_exec.c.
> 
> Would it make sense to remove the check all together?

I think this is ok. You used to have to worry about it, because the kernel let
you exec something with empty argv. And there's still perhaps a portability
concern. But old workarounds need to die sometime. I support removing this,
but I'd like some one else to comment.

Reply via email to