On Thu, Sep 3, 2015 at 10:08 AM, Miod Vallat <m...@online.fr> wrote: > mkhybrid(8) does not seem to be maintained upstream. Here are a few > minor fixes to it: > - buffer overflows, spotted by -Wbounded. They are caused by the way > char name[] is defined in struct iso_directory_record in > src/iso9660.h; unfortunately too much of the code will require > adjustments, should the field be replaced with a sizeless array. > - always false comparisons on `unsigned char' architectures (arm, > powerpc).
Looks good to me, though I wonder if the "check for char less than zero" tests should be replaced with isascii((unsigned char)x), as that smells like the intent. Philip Guenther
