On Sat, Sep 12, 2015 at 09:57:23PM +0200, Martin Pieuchot wrote:
> Did I miss something else?
I did not find anything. OK bluhm@
> @@ -1536,15 +1541,18 @@ struct nd_pfxrouter *
> find_pfxlist_reachable_router(struct nd_prefix *pr)
> {
> struct nd_pfxrouter *pfxrtr;
> - struct rtentry *rt;
> + struct rtentry *rt = NULL;
> struct llinfo_nd6 *ln;
This initialisation is not necessary anymore. But it does not hurt.
>
> LIST_FOREACH(pfxrtr, &pr->ndpr_advrtrs, pfr_entry) {
> if ((rt = nd6_lookup(&pfxrtr->router->rtaddr, 0,
> pfxrtr->router->ifp, pfxrtr->router->ifp->if_rdomain)) &&
> (ln = (struct llinfo_nd6 *)rt->rt_llinfo) &&
> - ND6_IS_LLINFO_PROBREACH(ln))
> + ND6_IS_LLINFO_PROBREACH(ln)) {
> + rtfree(rt);
> break; /* found */
> + }
> + rtfree(rt);
> }
>
> return (pfxrtr);
