On Fri, Sep 11, 2015 at 09:18:18PM +0200, Maxime Villard wrote:
> Got some time tonight; nothing new, just emptying my list:
>
> http://m00nbsd.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html#Unsorted-2
>
> Summary:
>
> _17/ UNINITIALIZED VARIABLE: sys/netinet/if_ether.c rev1.165
> _18/ UNINITIALIZED VARIABLE: sys/net80211/ieee80211_pae_output.c rev1.20
> _19/ UNINITIALIZED VARIABLE: sys/arch/i386/i386/bios.c rev1.112
> _20/ UNINITIALIZED VARIABLE: sys/arch/sgi/dev/if_iec.c rev1.14
> _21/ UNINITIALIZED VARIABLE: sys/arch/armv7/omap/ti_iic.c rev1.2
> _22/ OVERLAP: sys/arch/sparc64/dev/vdsp.c rev1.2
> _23/ USE-AFTER-FREE: sys/dev/sun/z8530ms.c rev1.2
> _24/ MEMORY LEAK: sys/dev/ic/oosiop.c rev1.22
>
Fix for _17
--
:wq Claudio
Index: netinet/if_ether.c
===================================================================
RCS file: /cvs/src/sys/netinet/if_ether.c,v
retrieving revision 1.168
diff -u -p -r1.168 if_ether.c
--- netinet/if_ether.c 13 Sep 2015 17:53:44 -0000 1.168
+++ netinet/if_ether.c 14 Sep 2015 04:42:08 -0000
@@ -367,10 +367,11 @@ arpresolve(struct ifnet *ifp, struct rte
"local address\n", __func__, inet_ntop(AF_INET,
&satosin(dst)->sin_addr, addr, sizeof(addr)));
} else {
+ la = NULL;
if ((rt = arplookup(satosin(dst)->sin_addr.s_addr, 1, 0,
ifp->if_rdomain)) != NULL)
la = ((struct llinfo_arp *)rt->rt_llinfo);
- else
+ if (la == NULL)
log(LOG_DEBUG, "%s: %s: can't allocate llinfo\n",
__func__,
inet_ntop(AF_INET, &satosin(dst)->sin_addr,
