On 10 October 2015 at 20:02, Alexandr Nedvedicky <[email protected]> wrote: > Hello, > > Patch fixes two small nits related to source node table in PF (a.k.a. > pf_src_tree_tracking). > > The first issue comes to `global` argument of pf_insert_src_node(). It is > always 0 everywhere in source code. The `global` is supposed to indicate > whether particular state is bound to global/main rule or to rule created on > behalf of admin. However in reality PF always uses 0 for `global` everywhere. > > The second issue is related to pf_remove_src_node() function, which refuses > the remove source node from table (pf_src_tree_tracking) if node to be removed > is not bound to rule (sn->rule.ptr == NULL). Such node would hang in tree > forever. I think we never hit this problem, since source node is always > bound to rule. > > OK? > > thanks and > regards > sasha >
OK mikeb
