On 16 October 2015 at 13:28, Alexandr Nedvedicky
<[email protected]> wrote:
>
> may be it's kind of bike shading...
> How about make kifs to stick to convention we see for other objects
> such as rulesets/anchors:
>
> pfi_kif_find()
> pfi_kif_find_or_create()
>
Personally I don't like "_or_create" style of function naming and
I would rather see those renamed to something else....
> and kill pfi_kif_get() completely, just to avoid confusion/surprise.
>
I kinda like pfi_kif_get interface and apart from this particular
case where I can also use clenching my teeth, it manages to get the
point across: kif objects might not represent any actual interface
but act as a placeholder and you always have to have one ("any").
It might be worth elaborating here as well that removing pfi_kif_get
in other places appears to be wrong: for instance when you're loading
states from a file you want to create placeholder objects for non-
existent pseudo or hotpluggable interfaces.
So yeah, I'm a bit on a fence about this one.
> anything else makes a sense to me.
>
> regards
> sasha
>
