On Fri, Oct 16, 2015 at 03:09:03PM +0200, Martin Pieuchot wrote:
> - if (rt->rt_flags & (RTF_REJECT | RTF_BLACKHOLE) ||
> - (rt->rt_flags & RTF_UP) == 0) {
> + if (!rtisvalid(rt) || ISSET(rt->rt_flags, RTF_REJECT|RTF_BLACKHOLE)) {
Why change to ISSET()? I still don't know which variant I like
more and the code is very inconsistent. So I don't care much.
> - if (ro->ro_rt != NULL &&
> - (ro->ro_rt->rt_flags & (RTF_UP | RTF_HOST)) &&
> + if (rtisvalid(ro->ro_rt) &&
> + ISSET(ro->ro_rt->rt_flags, RTF_HOST) &&
This is not equivalent. Before RTF_UP or RTF_HOST was checked,
now it is RTF_UP and RTF_HOST. Is this change intensional?
bluhm
