j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes:

> Frederic Nowak <f...@mailbox.org> writes:
>
>> Hi there,
>
> Hi,
>
>> at the moment ftp pledges "proc exec" in its SMALL version, but not
>> otherwise. This seems wrong, because the SMALL version does not support
>> interactive mode (which needs "proc exec" for e.g. the page command),
>> while the !SMALL version does.
>> The patch below switches the two pledges, so that the SMALL version
>> pledges a smaller subset.
>
> I can confirm that it is possible to have ftp(1) killed by pledge in the
> non-SMALL build.
>
> The diff looks correct and I doubt that there's a risk for it to
> introduce further regressions.  However there's a popen() call in
> recvrequest() that could trigger pledge protection.  If anyone wants to
> make sense of that code, be my guest...

Since no one stepped up to investigate this issue, I committed your diff
as is.  Thanks!

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to