> Hi, > > On Fri, Nov 06, 2015 at 05:39:03AM +0000, Miod Vallat wrote: > > Running regress/lib/libcrypto/aead fails on big-endian platforms without > > the following diff, for the ``Test vector from RFC7539 2.8.2'' test, due > > to 64-bit counters being truncated to size_t. > > > > Yes, the counter should be unsigned 64bit. > > OK reyk@
But note that will require a .so major version bump, as the API changes on 32-bit systems. > I can only see one other *int64_t in LibreSSL's API, should it be > unsigned long long? Or is it OK to start using C99 types in the API? (yes!) <stdint.h> types are definitely welcome. > The comment "converting size_t to u8" should also be updated: Indeed. Thanks for noticing.
