>On Sat, Nov 07, 2015 at 12:12:55AM -0500, Michael McConville wrote:
>> Ted Unangst wrote:
>> > less has a peculiar estrdup function. unlike ecalloc etc., it only
>> > prints an error but doesn't quit. But the callers don't seem to check
>> > for null. And in many places they call a function called save()
>> > instead.
>> > 
>> > It is clearer to make estrdup() quit and use it everywhere.
>> 
>> ok mmcc@
>> 
>> That said, error()'s name very strongly implies that it quits, so we
>> should look into fixing that too.
>
>I don't think it implies anything of the sort, an error is still an
>error if it doesn't kill the program.

Feeling a lot of dejavu here.

Reply via email to