Alexandre Ratchov wrote: > On Sun, Nov 08, 2015 at 09:56:23AM +0800, Michael W. Bombardieri wrote: > > On Thu, Nov 05, 2015 at 03:50:29PM +0100, Tobias Stoeckmann wrote: > > > On Thu, Nov 05, 2015 at 09:50:48AM +0000, Nicholas Marriott wrote: > > > > I don't know why cvs and rcs xmalloc.c has ended up so different. > > > > > > It's not just about cvs and rcs: > > > > > > /usr/src/usr.bin/cvs/xmalloc.c > > > /usr/src/usr.bin/diff/xmalloc.c > > > /usr/src/usr.bin/file/xmalloc.c > > > /usr/src/usr.bin/rcs/xmalloc.c > > > /usr/src/usr.bin/ssh/xmalloc.c > > > /usr/src/usr.bin/tmux/xmalloc.c (probably not same origin) > > > > > > > > > Also note that aucat(1)'s utils.c contains xmalloc() and xfree(). > > Its version of xfree() contains no special logic so remove it? > > i'd prefer we keep xfree(), as sometimes i replace it with a > instrumented version that detects leaks and gathers statistics
I don't think this is a good reason, honestly. It's easy to add a wrapper function/macro while debugging and replace all free() calls with it.
