Just look at the trouble changing one int->size_t is causing in lex ;-).


On Sun, Nov 22, 2015 at 08:18:55AM +0000, Nicholas Marriott wrote:
> On Sun, Nov 22, 2015 at 01:59:07AM +0000, B?hler  Theo wrote:
> > > It seems apparent that they never go negative. All instances are used to
> > > manipulate strlen() values.
> > >
> > > ok?
> > 
> > the first hunk is fine with me. I don't understand the second one:
> > why only convert w? Aren't all three ints guaranteed to be unsigned there?
> 
> Don't change i to size_t, it is not a size. Personally I wouldn't change
> this, int instead of size_t is everywhere in code this old, it would be
> a lot of churn, I don't think it necessarily improves anything and the
> risk of a mistake is high.

Reply via email to