On Sat, Nov 21, 2015 at 12:37:58PM +0100, Martin Pieuchot wrote: > On 20/11/15(Fri) 18:05, Alexandr Nedvedicky wrote: > > Hello, > > > > I have just nit comments, feel free to ignore them. > > > > 1) would it be possible to use closing #endif guards as follows: > > #endif /* NCARP */ > > Done. >
thanks a lot. I'm fine with your patch. OK regards sasha > > it's detail, given at some point in future we will probably have to use > > if_put()/if_get() for ifp's bound to kif's (right?). > > Well not necessarily. kif have the same lifetime as an ifp and are easy > to garbage collect so there's no need for the moment to use index for > them. Indexes are useful when two objects having a different lifetime > need to be linked at some point. By using indexes/id/cookie we do not > increase the lifetime of an object like with references but this has the > cost of a layer of indirection. and thanks for clarification here.
