Bob Beck wrote: > On Fri, Nov 27, 2015 at 02:50:57PM -0200, Walter Neto wrote: > > You have a number of places here where you introduce a line of 8 spaces > after your #endif - please clean up the trailing spaces, they shouldn't be > there. > > You also have uses of B_METAONLY that are not inside a #ifdef WAPBL in > ffs_balloc.c > > The first one I mostly get - as we are only looking for the first indirect > block > this makes sense. the second usage I'm not sure is correct... is it?
> > @@ -670,10 +684,11 @@ ffs2_balloc(struct inode *ip, off_t off, int size, > > struct ucred *cred, > > } > > > > if (pref == 0) > > - pref = ffs2_blkpref(ip, lbn, i - num - 1, NULL); > > + pref = ffs2_blkpref(ip, lbn, i - num - 1, > > + flags | B_METAONLY, NULL); > > > > - error = ffs_alloc(ip, lbn, pref, (int) fs->fs_bsize, cred, > > - &newb); > > + error = ffs_alloc(ip, lbn, pref, (int) fs->fs_bsize, > > + flags | B_METAONLY, cred, &newb); I'm ok with leaving this flag unguarded by ifdef. There's no functional change if the code *testing* the flag is guarded. The less intrusive the changes to code that doesn't really care, the better.
