Hi Sebastien, Sebastien Marie wrote on Tue, Dec 08, 2015 at 07:06:57AM +0100: > On Tue, Dec 08, 2015 at 01:19:35AM +0100, Ingo Schwarze wrote:
>> i'd like to propose a simplified version of this patch Frederic Nowak >> posted a few weeks ago for commit. Our experience is probably >> not yet sufficient to develop a full-blown solution for all UTF-8 >> problems in ksh(1), but this is very non-intrusive and makes the >> following commands better without breaking anything: >> >> * Ctrl-b, Ctrl-xd, Esc-[D, Esc-OD (backward-char) >> * Ctrl-f, Ctrl-xc, Esc-[C, Esc-OC (forward-char) >> * Ctrl-h, Ctrl-? (delete-char-backward) >> * Esc-[3~ (delete-char-forward) >> * Ctrl-k (kill-to-eol) > While testing ksh, I found the following problem, that I will try to > describe. But I dunno if it is just a case no-managed by your patch. Yes, i noticed that, but decided against trying to handle it in the same patch. I looks like that problem can be seperated from making the above commands work better. Maybe Frederic's original patch already handles that, too, maybe not. In cut(1), it was OK to drop in a large patch doing three things at once, even though that made review harder; allowing us to move faster. By contrast, in a shell, i'd prefer moving as slowly as possible and treading as carefully as possible. Once this is in, let's look at the next step. :-) (But i'll wait a day or so for more OKs or objections before committing based on OK tedu@ semarie@) > It looks like a problem in "inserting a UTF-8 char inside the line > (opposed to 'at end of line')". True. > Else your patch is pretty readable, and it would be a good first step. Thanks for checking! Yours, Ingo
