On Tue, Dec 22, 2015 at 06:42:23PM +0900, Masao Uebayashi wrote: > On Mon, Dec 21, 2015 at 03:53:09PM +0100, Mark Kettenis wrote: > > > Date: Mon, 21 Dec 2015 22:47:19 +0900 > > > From: Masao Uebayashi <[email protected]> > > > > > > ipmi(4) has checked thresholds of some sensing values and reported false > > > alarms. This patch reverts those checks. > > > > > > This also changes ipmi(4) to handle disabled sensors while allowing them > > > to > > > supply readings if they want. > > > > > > >From Jonathan Matthew. > > > > > > OK? > > > > Sorry, but I don't understand what the problem is here. > > > > Is the code wrong? Or did you encounter a machine that has bogus > > thresholds? > > From jmatthew@: > > > Here's a Dell 2950: > > > > ipmi0 at mainbus0: version 1.5 interface KCS iobase 0xa2/2 spacing 1 irq 25 > > > > hw.sensors.ipmi0.temp0=-57.00 degC (Temp), OK > > hw.sensors.ipmi0.temp1=-56.00 degC (Temp), OK > > hw.sensors.ipmi0.temp2=40.00 degC (Temp), WARNING > > hw.sensors.ipmi0.temp3=40.00 degC (Temp), OK > > hw.sensors.ipmi0.temp4=22.00 degC (Ambient Temp), OK > > hw.sensors.ipmi0.fan0=6750 RPM (FAN 1 RPM), OK > > hw.sensors.ipmi0.fan1=6600 RPM (FAN 2 RPM), OK > > hw.sensors.ipmi0.fan2=6750 RPM (FAN 3 RPM), OK > > hw.sensors.ipmi0.fan3=6675 RPM (FAN 4 RPM), OK > > hw.sensors.ipmi0.fan4=4200 RPM (FAN 5 RPM), OK > > hw.sensors.ipmi0.fan5=4200 RPM (FAN 6 RPM), WARNING > > hw.sensors.ipmi0.volt0=300.00 VDC (Voltage 1), CRITICAL > > hw.sensors.ipmi0.volt1=302.00 VDC (Voltage 2), CRITICAL > > hw.sensors.ipmi0.indicator0=On (Status), OK > > hw.sensors.ipmi0.indicator1=On (Status), OK > > hw.sensors.ipmi0.indicator2=Off (Intrusion), OK > > > > the voltage readings seem a bit unlikely to me. > > > > and a sun v20z: > > > > ipmi0 at mainbus0: version 2.0 interface KCS iobase 0xca8/8 spacing 4 > > > > hw.sensors.ipmi0.temp0=31.20 degC (thor.temp), OK > > hw.sensors.ipmi0.temp1=33.00 degC (golem.temp), OK > > hw.sensors.ipmi0.temp2=28.80 degC (cpu0.temp), WARNING > > hw.sensors.ipmi0.temp3=30.00 degC (cpu1.temp), OK > > hw.sensors.ipmi0.temp4=33.00 degC (sp.temp), OK > > hw.sensors.ipmi0.temp5=33.00 degC (gbeth.temp), OK > > hw.sensors.ipmi0.temp6=28.20 degC (cpu1.memtemp), OK > > hw.sensors.ipmi0.temp7=35.40 degC (cpu1.dietemp), OK > > hw.sensors.ipmi0.temp8=16.20 degC (ambienttemp), OK > > hw.sensors.ipmi0.temp9=25.80 degC (cpu0.memtemp), WARNING > > hw.sensors.ipmi0.temp10=31.20 degC (cpu0.dietemp), WARNING > > hw.sensors.ipmi0.temp11=20.40 degC (hddbp.temp), CRITICAL > > hw.sensors.ipmi0.fan0=13860 RPM (fan3.tach), CRITICAL > > hw.sensors.ipmi0.fan1=0 RPM (fan4.tach), CRITICAL > > hw.sensors.ipmi0.fan2=0 RPM (fan5.tach), CRITICAL > > hw.sensors.ipmi0.fan3=0 RPM (fan6.tach), OK > > hw.sensors.ipmi0.fan4=14040 RPM (fan1.tach), CRITICAL > > hw.sensors.ipmi0.fan5=13980 RPM (fan2.tach), CRITICAL > > hw.sensors.ipmi0.volt0=12.10 VDC (bulk.v12-0-s0), OK > > hw.sensors.ipmi0.volt1=12.10 VDC (bulk.v12-1-s0), OK > > hw.sensors.ipmi0.volt2=3.36 VDC (bulk.v3_3-s0), CRITICAL > > hw.sensors.ipmi0.volt3=1.20 VDC (cpu0.vldt2), CRITICAL > > hw.sensors.ipmi0.volt4=1.56 VDC (cpu0.vcore-s0), WARNING > > hw.sensors.ipmi0.volt5=5.10 VDC (bulk.v5-s0), WARNING > > hw.sensors.ipmi0.volt6=2.52 VDC (cpu0.v2_5-s3), OK > > hw.sensors.ipmi0.volt7=1.20 VDC (cpu0.vtt-s3), CRITICAL > > hw.sensors.ipmi0.volt8=3.36 VDC (bulk.v3_3-s5), WARNING > > hw.sensors.ipmi0.volt9=3.36 VDC (bulk.v3_3-s3), WARNING > > hw.sensors.ipmi0.volt10=1.56 VDC (cpu1.vcore-s0), WARNING > > hw.sensors.ipmi0.volt11=5.05 VDC (bulk.v5-s5), WARNING > > hw.sensors.ipmi0.volt12=2.52 VDC (cpu1.v2_5-s3), WARNING > > hw.sensors.ipmi0.volt13=1.20 VDC (cpu1.vtt-s3), CRITICAL > > hw.sensors.ipmi0.volt14=2.52 VDC (cpu0.v2_5-s0), CRITICAL > > hw.sensors.ipmi0.volt15=1.80 VDC (bulk.v1_8-s5), CRITICAL > > hw.sensors.ipmi0.volt16=1.20 VDC (g.vldt1), WARNING > > hw.sensors.ipmi0.volt17=2.52 VDC (bulk.v2_5-s0), CRITICAL > > hw.sensors.ipmi0.volt18=1.80 VDC (bulk.v1_8-s0), CRITICAL > > hw.sensors.ipmi0.volt19=1.20 VDC (cpu0.vldt1), CRITICAL > > hw.sensors.ipmi0.volt20=2.52 VDC (bulk.v2_5-s5), CRITICAL > > > > 'ipmitool sdr' over the network gives the same readings, but says these > > are all ok rather than warning or critical. >
After I looked at the ipmitool code and discovered it just uses the reported sensor status rather than doing threshold checks itself, I changed ipmi(4) to match and then all the sensors were OK, except when things were genuinely wrong. Is there a reason we should do the threshold checks rather than just looking at the status reported right next to the sensor reading?
