On Sat, Dec 26, 2015 at 09:57:57PM +0000, Jason McIntyre wrote:
> On Sat, Dec 26, 2015 at 10:01:34AM +0100, Michal Mazurek wrote:
> > Index: factor.6
> > ===================================================================
> > RCS file: /cvs/src/games/factor/factor.6,v
> > retrieving revision 1.12
> > diff -u -p -r1.12 factor.6
> > --- factor.6        24 Jan 2011 00:42:44 -0000      1.12
> > +++ factor.6        26 Dec 2015 08:56:37 -0000
> > @@ -58,7 +58,7 @@ When a number is factored, it is printed
> >  and the list of factors on a single line.
> >  Factors are listed in ascending order, and are preceded by a space.
> >  If a factor divides a value more than once, it will be printed
> > -more than once.
> > +that number of times.
> >  .Pp
> >  When
> >  .Nm
> > 
> 
> i am not the right guy to take this but i want to point out that
> the source code has virtually the same comment as the man page, so
> if someone agrees the man page needs changed they might want to
> bump the source code too.

Yes, the current phrasing is a bit vague.  I'm not convinced the
suggestion is better, since it still leaves the number of times a
factor is printed undefined.  How about:

Index: factor.6
===================================================================
RCS file: /var/cvs/src/games/factor/factor.6,v
retrieving revision 1.12
diff -u -p -r1.12 factor.6
--- factor.6    24 Jan 2011 00:42:44 -0000      1.12
+++ factor.6    26 Dec 2015 22:04:54 -0000
@@ -57,8 +57,7 @@ When a number is factored, it is printed
 .Sq \&: ,
 and the list of factors on a single line.
 Factors are listed in ascending order, and are preceded by a space.
-If a factor divides a value more than once, it will be printed
-more than once.
+Every factor is printed as often as it divides the number.
 .Pp
 When
 .Nm

Reply via email to