On Sun, Dec 27, 2015 at 08:28:36PM +0100, Alexander Hall wrote: > Hi, > > Recently, my window manager (i3) started making the ssh-askpass windows > too small to be really usable. The problem seems to be that the size > hints indicate that it provides a width and height, while those fields > are set to 0. While looking at this, the same seems to be the case for > position (x and y are 0). AFAICS, both of these hints are obsolete. > > The diff below (even without the PPosition removal, but I added that > for good measure) fixes this, at least for i3. > > Should this rather be taken upstream, if any, if it's not already > there, in which case it might already be fixed? > > Anyway, the diff follows. Please test on your favourite window manager. > > OK? Comments?
I can confirm both the issue and that your patch fixes this for i3. Thanks > /Alexander > > > Index: x11-ssh-askpass.c > =================================================================== > RCS file: /cvs/xenocara/app/ssh-askpass/x11-ssh-askpass.c,v > retrieving revision 1.6 > diff -u -p -r1.6 x11-ssh-askpass.c > --- x11-ssh-askpass.c 24 Apr 2015 02:19:41 -0000 1.6 > +++ x11-ssh-askpass.c 27 Dec 2015 18:52:55 -0000 > @@ -772,8 +772,6 @@ void createDialogWindow(AppInfo *app) > outOfMemory(app, __LINE__); > } > d->sizeHints->flags = 0; > - d->sizeHints->flags |= PPosition; > - d->sizeHints->flags |= PSize; > d->sizeHints->min_width = d->w3.w.width; > d->sizeHints->min_height = d->w3.w.height; > d->sizeHints->flags |= PMinSize; > Index: x11-ssh-askpass.c > =================================================================== > RCS file: /cvs/xenocara/app/ssh-askpass/x11-ssh-askpass.c,v > retrieving revision 1.6 > diff -u -p -r1.6 x11-ssh-askpass.c > --- x11-ssh-askpass.c 24 Apr 2015 02:19:41 -0000 1.6 > +++ x11-ssh-askpass.c 27 Dec 2015 18:52:55 -0000 > @@ -772,8 +772,6 @@ void createDialogWindow(AppInfo *app) > outOfMemory(app, __LINE__); > } > d->sizeHints->flags = 0; > - d->sizeHints->flags |= PPosition; > - d->sizeHints->flags |= PSize; > d->sizeHints->min_width = d->w3.w.width; > d->sizeHints->min_height = d->w3.w.height; > d->sizeHints->flags |= PMinSize;
