Michael McConville wrote: > Michael McConville wrote: > > Michael McConville wrote: > > > > On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev <pugachev...@gmail.com> > > > > wrote: > > > > > Hi, > > > > > > > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > > > > copystr/copyinstr returns an error, we need to set *tmpsap to NULL to > > > > > terminate a loop (under "fail" label) correctly. > > > > > > I spent a while straining to see the forest through the trees, but this > > > makes sense to me. ok mmcc@ > > > > > > Is this allocation chain idiom used elsewhere in sys/kern? Maybe we > > > could break it out into ~3 functions. The current state of affairs seems > > > bug-prone. > > > > It seems that all possible paths through this nested condition increment > > tmpsap. Why not just increment it afterward so no one else ends up with > > the headache I now have? > > > > As always: I could be misinterpreting this. > > tedu and gsoares pointed out the nop expression in my last diff. I guess > I was moving too fast... > > Here's a new one:
this looks better to me.
