​Hi Ted,

FWIW, I agree with malloc always failing on error.​

On Wed, Dec 30, 2015 at 7:12 AM, Ted Unangst <t...@tedunangst.com> wrote:

> @@ -523,10 +521,8 @@ omalloc_init(struct dir_info **dp)
>                                 mopts.malloc_cache >>= 1;
>                                 break;
>                         case 'a':
> -                               mopts.malloc_abort = 0;
>                                 break;
>                         case 'A':
> -                               mopts.malloc_abort = 1;
>                                 break;
>                         case 'c':
>                                 mopts.malloc_canaries = 0;
>

​I guess you will remove the option treatment ​in a near future ?  ;-)

On a side note, with this option var removal, you can collapse the switch
condition as :
@@ -523,10 +521,7 @@ omalloc_init(struct dir_info **dp)
                                mopts.malloc_cache >>= 1;
                                break;
                        case 'a':
-                               mopts.malloc_abort = 0;
-                               break;
                        case 'A':
-                               mopts.malloc_abort = 1;
                                break;
                        case 'c':
                                mopts.malloc_canaries = 0;


​Thierry​

Reply via email to