On 20/01/16(Wed) 06:28, Andreas Kusalananda Kähäri wrote: > Previously sent to misc@, but I was told to send it here instead.
ok mpi@ > > Cheers, > Andreas > > ----- Forwarded message from Andreas Kusalananda Kähäri > <[email protected]> ----- > > Date: Mon, 18 Jan 2016 16:33:34 +0100 > From: Andreas Kusalananda Kähäri <[email protected]> > To: openbsd-misc <[email protected]> > Subject: Quoting ${CC} expansion in libiberty Makefile > > Hi, > > I tried running the base system build with CC="ccache cc" and it broke > while compiling libiberty due to an unquoted expansion of ${CC} in the > Makefile ("${MAKE} ${GNUCFLAGS} CC=${CC} needed-list"). > > I know I won't save much time by using ccache since the compiler is > rebuilt during the process, but I assume that a similar problem would > arise if one tried to use CC="distcc cc", for example. Also, other > Makefiles in the tree quotes ${CC}, and this is *almost* the sole > instance where it's not quoted. Other instances are > lib/libcrypto/crypto/arch/{mips64,sparc64}/Makefile.inc > > Patch: > > Index: Makefile.bsd-wrapper > =================================================================== > RCS file: /cvs/src/gnu/lib/libiberty/Makefile.bsd-wrapper,v > retrieving revision 1.15 > diff -u -p -u -r1.15 Makefile.bsd-wrapper > --- Makefile.bsd-wrapper 31 Aug 2014 01:02:48 -0000 1.15 > +++ Makefile.bsd-wrapper 18 Jan 2016 15:28:44 -0000 > @@ -32,7 +32,7 @@ CLEANFILES+= Makefile config.cache confi > depend: needed-list > > needed-list: config.status > - ${MAKE} ${GNUCFLAGS} CC=${CC} needed-list > + ${MAKE} ${GNUCFLAGS} CC="${CC}" needed-list > > config.status: Makefile.in configure > PATH="/bin:/usr/bin:/sbin:/usr/sbin" \ > > > > -- > Andreas Kusalananda Kähäri, Bioinformatics Developer, Uppsala, Sweden > OpenPGP: url=https://db.tt/2zaB1E7y; id=46082BDF > ------------------------------------------------------------------------ > > > > ----- End forwarded message ----- > > -- > Andreas Kusalananda Kähäri, Bioinformatics Developer, Uppsala, Sweden > OpenPGP: url=https://db.tt/2zaB1E7y; id=46082BDF > ------------------------------------------------------------------------
