On 2016/01/26 20:16, Michael McConville wrote: > Stuart Henderson wrote: > > On 2016/01/25 22:52, Michael McConville wrote: > > > fddi_bitswap is only used once, and it just adds a layer of > > > indirection to its preprocessor condition. > > > > Oh yuk. This is bogus anyway, and there's no good way to handle it. We > > dropped support for FDDI interfaces so it only affect decodes of pcap > > files, and who knows where they were created? > > I'm not familiar with FDDI and I'm new to tcpdump, so I can't offer much > input. How much do you think can/should be removed?
FDDI is a dual token-ring network based on 100Mb fibre connections, often over larger distances (campus/metro) than a typical lan. It's obsolete, we removed support for the adapters, the only place this code could possibly be used now is for parsing pcap files captured on another system or from older OpenBSD (and there's a kitchen-sink pcap decoder in ports these days..). This bitswap thing is because some OS bitswap the network addresses (in the driver or somewhere; they are swapped in pcap files) and some don't. I don't think that it's particularly useful for OpenBSD to support decoding this any more. Maybe we should stop rearranging these deckchairs and borrow tedu's axe instead.
