On Mon, Feb 01, 2016 at 07:37:34PM +0100, Jérémie Courrèges-Anglas wrote: > j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > > > Sebastien Marie <sema...@openbsd.org> writes: > > > >> On Sun, Jan 31, 2016 at 09:39:52AM +0100, Landry Breuil wrote: > >>> Hi, > >>> > >>> i'm tinkering with ldapd and writing regress tests for it, and to > >>> allow running independent instances (with separate port/control > >>> socket/etc) i needed to add the possibility to specify an alternative > >>> datadir, which was so far #defined in the code. > >>> Patch is pretty simple and works fine, i'm open to suggestions of course > >>> on a better wording for the manpage and option choose (i went for -r..) > >>> okays welcome too ! > >>> > >> > >> the diff looks good and it would permit to make regress tests, so OK > >> semarie@ :) > > > > I have smallish tweaks to propose but nothing that prevents this diff to > > go in as is. ok jca@ > > Since both ldapd and ldapctl may access the db, ldapctl should be > modified similarly.
Mh, i have to admit i thought ldapctl was sending imsgs commands to ldapd to do the actual compact/reindexing instead of doing it offline.. so yes this makes sense, just add the chdir() check as gsoares@ proposed for ldapd. Landry
