There has to be a blank line after the sys includes.
Edgar Pettijohn wrote:
> --- io.c.orig Sun Mar 6 12:43:12 2016
> +++ io.c Sun Mar 6 12:43:36 2016
> @@ -37,7 +37,9 @@
>
> /* Re-coding of advent in C: file i/o and user i/o */
>
> +#include <sys/types.h>
> #include <err.h>
> +#include <signhal.h>
> #include <stdio.h>
> #include <string.h>
> #include <stdlib.h>
> --- subr.c.orig Sun Mar 6 12:39:53 2016
> +++ subr.c Sun Mar 6 12:42:36 2016
> @@ -37,8 +37,11 @@
>
> /* Re-coding of advent in C: subroutines from main */
>
> +#include <sys/types.h>
> +#include <signhal.h>
> #include <stdio.h>
> #include <stdlib.h>
> +#include <string.h>
> #include "hdr.h"
> #include "extern.h"
>
> --- wizard.c.orig Sun Mar 6 12:40:09 2016
> +++ wizard.c Sun Mar 6 12:40:59 2016
> @@ -37,11 +37,12 @@
>
> /* Re-coding of advent in C: privileged operations */
>
> +#include <sys/types.h>
> #include <limits.h>
> +#include <signal.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> -
> #include "extern.h"
> #include "hdr.h"
>
>
>
> On 03/06/16 12:35, Michael McConville wrote:
> >The sys includes should be first and separate. See style(9).
> >
> >Edgar Pettijohn wrote:
> >>--- crc.c.orig Sun Mar 6 10:31:34 2016
> >>+++ crc.c Sun Mar 6 10:31:55 2016
> >>@@ -33,6 +33,7 @@
> >> * SUCH DAMAGE.
> >> */
> >>
> >>+#include <sys/types.h>
> >> #include "extern.h"
> >>
> >> unsigned long crctab[] = {
> >>--- done.c.orig Sun Mar 6 10:40:59 2016
> >>+++ done.c Sun Mar 6 10:42:25 2016
> >>@@ -37,8 +37,10 @@
> >>
> >> /* Re-coding of advent in C: termination routines */
> >>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>+#include <sys/types.h>
> >> #include "hdr.h"
> >> #include "extern.h"
> >>
> >>--- extern.h.orig Sun Mar 6 10:24:01 2016
> >>+++ extern.h Sun Mar 6 10:24:10 2016
> >>@@ -30,9 +30,6 @@
> >> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >> */
> >>
> >>-#include <sys/types.h>
> >>-#include <string.h>
> >>-
> >> /* crc.c */
> >> void crc_start(void);
> >> unsigned long crc(const char *, int);
> >>--- hdr.h.orig Sun Mar 6 10:40:26 2016
> >>+++ hdr.h Sun Mar 6 10:40:43 2016
> >>@@ -52,9 +52,6 @@
> >>
> >> /* hdr.h: included by c advent files */
> >>
> >>-#include <sys/types.h>
> >>-#include <signal.h>
> >>-
> >> int datfd; /* message file descriptor */
> >> volatile sig_atomic_t delhit;
> >> int yea;
> >>--- io.c.orig Sun Mar 6 10:47:06 2016
> >>+++ io.c Sun Mar 6 10:47:42 2016
> >>@@ -38,9 +38,11 @@
> >> /* Re-coding of advent in C: file i/o and user i/o */
> >>
> >> #include <err.h>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <string.h>
> >> #include <stdlib.h>
> >>+#include <sys/types.h>
> >> #include "hdr.h"
> >> #include "extern.h"
> >>
> >>--- main.c.orig Sun Mar 6 10:25:22 2016
> >>+++ main.c Sun Mar 6 10:25:38 2016
> >>@@ -41,6 +41,7 @@
> >> #include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>+#include <string.h>
> >> #include <unistd.h>
> >> #include "hdr.h"
> >> #include "extern.h"
> >>--- save.c.orig Sun Mar 6 10:42:59 2016
> >>+++ save.c Sun Mar 6 10:43:46 2016
> >>@@ -35,6 +35,7 @@
> >> * SUCH DAMAGE.
> >> */
> >>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >> #include "hdr.h"
> >>--- subr.c.orig Sun Mar 6 10:26:03 2016
> >>+++ subr.c Sun Mar 6 10:45:14 2016
> >>@@ -37,8 +37,11 @@
> >>
> >> /* Re-coding of advent in C: subroutines from main */
> >>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>+#include <string.h>
> >>+#include <sys/types.h>
> >> #include "hdr.h"
> >> #include "extern.h"
> >>
> >>--- vocab.c.orig Sun Mar 6 10:26:40 2016
> >>+++ vocab.c Sun Mar 6 10:46:00 2016
> >>@@ -38,8 +38,11 @@
> >> /* Re-coding of advent in C: data structure routines */
> >>
> >> #include <err.h>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>+#include <string.h>
> >>+#include <sys/types.h>
> >> #include "hdr.h"
> >> #include "extern.h"
> >>
> >>--- wizard.c.orig Sun Mar 6 10:46:17 2016
> >>+++ wizard.c Sun Mar 6 10:46:55 2016
> >>@@ -38,9 +38,11 @@
> >> /* Re-coding of advent in C: privileged operations */
> >>
> >> #include <limits.h>
> >>+#include <signal.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >> #include <string.h>
> >>+#include <sys/types.h>
> >> #include "extern.h"
> >> #include "hdr.h"
> >>
>
