On Thu, 31 Mar 2016 09:34:32 +0200, Martin Natano wrote: > Thank you all for the input. Allocatig the bitmap via malloc() really > seems like the way to go, so we don't waste space for non-cloning > devices. See updated patch below. > > Would it make sense to move the (rdev == VCHR && ...) condition to a > macro in <sys/specdev.h>? I figured it's only used twice, so I inlined > it.
I think it is fine to inline that but please put a set of parens around the bitwise and part for readability. - todd
