On Wed, Apr 06, 2016 at 02:45:46PM +0200, Michal Mazurek wrote:
> * document NOLOCK - copy and paste from the commit message.
That's useful.
> * mention INDIR and NOLOCK in 'Fields'.
How about something like "one of the types listed below, or one of the
compatibility options defined in syscalls.conf" instead?
> * sort the list of types in 'Fields'.
> * sort the list of types in 'types'.
I think the order was more logical before (most used type first).
> * place a dot ('.') at the end of each sentence.
Bike-shedding: Those are not full sentences, but only fragments. There
doesn't have to be a dot at the end.
>
> Index: sys/kern/syscalls.master
> ===================================================================
> RCS file: /cvs/src/sys/kern/syscalls.master,v
> retrieving revision 1.169
> diff -u -p -r1.169 syscalls.master
> --- sys/kern/syscalls.master 30 Mar 2016 07:49:11 -0000 1.169
> +++ sys/kern/syscalls.master 6 Apr 2016 12:40:27 -0000
> @@ -7,18 +7,19 @@
> ; (See syscalls.conf to see what it is processed into.)
> ;
> ; Fields: number type [type-dependent ...]
> -; number system call number, must be in order
> -; type one of STD, OBSOL, UNIMPL, NODEF, NOARGS, or one of
> -; the compatibility options defined in syscalls.conf.
> +; number system call number, must be in order.
> +; type one of INDIR, NOARGS, NODEF, NOLOCK, OBSOL, STD, UNIMPL, or
> +; one of the compatibility options defined in syscalls.conf.
> ;
> ; types:
> -; STD always included
> -; OBSOL obsolete, not included in system
> -; UNIMPL unimplemented, not included in system
> -; NODEF included, but don't define the syscall number
> -; NOARGS included, but don't define the syscall args structure
> ; INDIR included, but don't define the syscall args structure,
> ; and allow it to be "really" varargs.
> +; NOARGS included, but don't define the syscall args structure.
> +; NODEF included, but don't define the syscall number.
> +; NOLOCK the syscall doesn't grab any locks whatsoever.
> +; OBSOL obsolete, not included in system.
> +; STD always included.
> +; UNIMPL unimplemented, not included in system.
> ;
> ; The compat options are defined in the syscalls.conf file, and the
> ; compat option name is prefixed to the syscall name. Other than
>
> --
> Michal Mazurek
>
