> wskbd_enable (calls pckbd_enable) does not appear to be called from > wskbd_activate, perhaps just calling wskbd_enable from there would be > better? (as a matter of fact, wskbd_activate doesn't really do much at > all except set sc_dying=1, and I'm not sure where that gets reset.)
Nooooooo! wskbd_enable() is not used in the physical device activation path, but in the logical path, so that keyboard input gets ignored unless its device is actually opened. If you are running with serial console and no getty listening to /dev/ttyC*, for example, then wskbd_enable() should not get invoked at all! Now, some of the work done in wskbd_enable() might be worth doing in wskbd_activate(), but be very careful when changing this.
